Skip to content

[ja] Fix broken links in persistent-volumes#41770

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
highpon:ja/docs/concepts/storage/persistent-volumes
Jun 29, 2023
Merged

[ja] Fix broken links in persistent-volumes#41770
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
highpon:ja/docs/concepts/storage/persistent-volumes

Conversation

@highpon
Copy link
Contributor

@highpon highpon commented Jun 26, 2023

This PR fixes a broken link in the Japanese persistent-volumes document.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 26, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: highpon / name: s-shiraki (2f6e72e)

@k8s-ci-robot k8s-ci-robot requested review from atoato88 and ptux June 26, 2023 14:06
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 26, 2023

Welcome @highpon!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2023
@highpon highpon changed the title Fix broken links in persistent-volumes [ja] Fix broken links in persistent-volumes Jun 26, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 26, 2023
@atoato88
Copy link
Contributor

atoato88 commented Jun 27, 2023

/lgtm

Thank you for creating this PR!
The Update looks good for me!

But the CI for Netlify(a build system for generating webpage) said an error, this looks the error on Netlify side.

Could you empty-commit by doing following to retrigger the build?

git commit --amend --no-edit
git push -f

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 27, 2023

LGTM label has been added.

DetailsGit tree hash: ee40d09431196e7c5602a2e60ac6591ed285d983

@netlify
Copy link

netlify bot commented Jun 28, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2f6e72e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/649b852ad830320008a0fd75
😎 Deploy Preview https://deploy-preview-41770--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@highpon
Copy link
Contributor Author

highpon commented Jun 28, 2023

Thank you for your review!
I built again and the error on the Netlify side is fixed!

@atoato88
Copy link
Contributor

atoato88 commented Jun 28, 2023

Thank you for quick response!

@atoato88
Copy link
Contributor

atoato88 commented Jun 28, 2023

/assign @nasa9084
Could you review this?

nasa9084
nasa9084 reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thank you~

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit dee8702 into kubernetes:main Jun 29, 2023
@highpon highpon deleted the ja/docs/concepts/storage/persistent-volumes branch June 29, 2023 13:30
@highpon highpon mentioned this pull request Jul 30, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nasa9084 nasa9084 nasa9084 left review comments

@atoato88 atoato88 Awaiting requested review from atoato88

@ptux ptux Awaiting requested review from ptux

Assignees

@atoato88 atoato88

@nasa9084 nasa9084

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@highpon @k8s-ci-robot @atoato88 @nasa9084